[8.x] Explicitly set chromedriver port.
#1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #1123 fixes #1122 Before 128, ChromeDriver will use the default 9515 port, however this is no longer the case and would cause chromedriver to run on port 0. https://issues.chromium.org/issues/361370192 Signed-off-by: Mior Muhammad Zaki <[email protected]>
crynobone
commented
Aug 26, 2024
| @@ -43,7 +43,8 @@ protected function setUp(): void | |||
| protected function driver() | |||
| { | |||
| return RemoteWebDriver::create( | |||
| 'http://localhost:9515', DesiredCapabilities::chrome() | |||
| $_ENV['DUSK_DRIVER_URL'] ?? env('DUSK_DRIVER_URL') ?? 'http://localhost:9515', | |||
There was a problem hiding this comment.
Replicate line from stub file:
Line 43 in 4e76666
underdpt
added a commit
to underdpt/laravel-console-dusk
that referenced
this pull request
Aug 27, 2024
Chrome version 128 doesn't have a default port 9515 so dusk fails to connect to it. See: laravel/dusk#1124
This was referenced Aug 27, 2024
owenvoke
pushed a commit
to nunomaduro/laravel-console-dusk
that referenced
this pull request
Aug 27, 2024
Chrome version 128 doesn't have a default port 9515 so dusk fails to connect to it. See: laravel/dusk#1124
|
fyi, this is the commit that confirms this is an intentional change in ChromeDriver behavior: https://chromium.googlesource.com/chromium/src/+/6f33d75f071e322c4a3e49b0a4ac2022e5b6cada |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1123
fixes #1122
Before 128, ChromeDriver will use the default 9515 port, however this is no longer the case and would cause chromedriver to run on port 0. https://issues.chromium.org/issues/361370192